Skip to content

VAutoHider: cleanup size_allocate#940

Open
danirabbit wants to merge 3 commits intomasterfrom
danirabbit/vautohider-allocate-cleanup
Open

VAutoHider: cleanup size_allocate#940
danirabbit wants to merge 3 commits intomasterfrom
danirabbit/vautohider-allocate-cleanup

Conversation

@danirabbit
Copy link
Copy Markdown
Member

@danirabbit danirabbit commented Apr 9, 2026

  • Avoid nesting and using continue where possible
  • Brackets with if statements
  • DRY more_label hide and vexpand
  • rename height to shown_children_height for clarity

@danirabbit danirabbit requested a review from a team April 9, 2026 20:42
Copy link
Copy Markdown
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to alter the behaviour when there is only one event. The more_label appears when there is less space than the child height + more_label_height whereas in master it appears when there is less space available than the child_height. So the more_label appears earlier than necessary when shrinking the height.

It would simplify matters if we can assume/ensure the child height is constant and the same as the more_label height.

@danirabbit danirabbit requested a review from jeremypw April 10, 2026 18:31
@danirabbit
Copy link
Copy Markdown
Member Author

@jeremypw ah thanks for noticing that! I think it should be fixed now. The logic here was pretty hard to follow. Hopefully it's a little clearer now

Copy link
Copy Markdown
Collaborator

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected now, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants