Open
Conversation
jeremypw
requested changes
Apr 10, 2026
Collaborator
jeremypw
left a comment
There was a problem hiding this comment.
This seems to alter the behaviour when there is only one event. The more_label appears when there is less space than the child height + more_label_height whereas in master it appears when there is less space available than the child_height. So the more_label appears earlier than necessary when shrinking the height.
It would simplify matters if we can assume/ensure the child height is constant and the same as the more_label height.
Member
Author
|
@jeremypw ah thanks for noticing that! I think it should be fixed now. The logic here was pretty hard to follow. Hopefully it's a little clearer now |
jeremypw
approved these changes
Apr 11, 2026
Collaborator
jeremypw
left a comment
There was a problem hiding this comment.
Works as expected now, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continuewhere possiblemore_labelhide and vexpandheighttoshown_children_heightfor clarity