Skip to content

Conversation

tintou
Copy link
Member

@tintou tintou commented Mar 3, 2023

Update flatpak and add a small fix

Use rebase to merge it.

tintou added 3 commits March 3, 2023 20:59
Allows to use GNOME Builder directly and makes it easy to copy dependencies
from elsewhere.
I have been able to trigger this by changing the selected folder while it is loading.
Comment on lines 15 to 17
"--talk-name=org.gnome.evolution.dataserver.Calendar8",
"--talk-name=org.gnome.evolution.dataserver.Sources5",
"--talk-name=org.gnome.evolution.dataserver.UserPrompter0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think mail uses the Calendar and UserPrompter Services. don't need to expose them to the sandbox.

"type": "git",
"url": "https://gitlab.gnome.org/GNOME/evolution-data-server.git",
"tag": "3.40.2"
"branch": "3.46.4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is a tag, not a branch. Also, maybe it's better to keep the version here and in the OS in sync since we aren't really using the server from the sandbox.

Comment on lines +92 to +95
"type": "archive",
"url": "https://github.com/libical/libical/releases/download/v3.0.16/libical-3.0.16.tar.gz",
"sha256": "b44705dd71ca4538c86fb16248483ab4b48978524fb1da5097bd76aa2e0f0c33"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to prefer the archive over the git repo? if so, wouldn't be better to use archive for all dependencies?

Also, there's a extra space before the close brace.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flatpak is way more efficient when dealing with archives than git repositories (it only has to look at if the file is newer on the server before downloading it)

@danirabbit
Copy link
Member

@tintou is this branch still relevant? If so, can you resolve conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants