Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PolkitDialog: GTK4 Prep #73

Merged
merged 1 commit into from
Nov 11, 2023
Merged

PolkitDialog: GTK4 Prep #73

merged 1 commit into from
Nov 11, 2023

Conversation

danirabbit
Copy link
Member

Review with hide whitespace changes

  • Use modern code style
  • Use activates_default instead of manual keypress listening
  • Remove shake, always on top, skip taskbar because we can't position our own window in GTK 4/Wayland

@danirabbit danirabbit marked this pull request as ready for review October 11, 2023 19:55
@danirabbit danirabbit requested a review from a team October 11, 2023 19:55
@danirabbit danirabbit merged commit 9d92e99 into master Nov 11, 2023
@danirabbit danirabbit deleted the danirabbit/gtk4-prep branch November 11, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeebok zeebok zeebok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
GTK4 Porting
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @zeebok