-
-
Notifications
You must be signed in to change notification settings - Fork 11
LocaleManager: set system locale and keyboard via dbus #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Also, maybe we can update the
|
|
@ryonakano thanks for the thorough review! Addressed those feedback points :) |
ryonakano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small nitpicking, otherwise looks good and works as expected.
Co-authored-by: Ryo Nakano <ryonakaknock3@gmail.com>
|
@ryonakano thanks for catching that! |
ryonakano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good and works as expected. Thank you for your work!
|
Thanks for your thorough review! |
As recommended in #147 (comment)