Skip to content

InfoBox: add metered data switch #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danirabbit merged 3 commits into from
Dec 10, 2024
Merged

InfoBox: add metered data switch #414

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df324f0
InfoBox: add metered data switch
danirabbit Dec 10, 2024
f1da267
clarity
danirabbit Dec 10, 2024
6158155
Fix writing changes to the metered settings (#415)
ryonakano Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 58 additions & 0 deletions src/Widgets/InfoBox.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ public class Network.Widgets.InfoBox : Gtk.Box {
private Gtk.Label dns;
private Gtk.Label sent;
private Gtk.Label received;
private Gtk.Switch reduce_data_switch;
private Granite.HeaderLabel ip6address_head;
private NM.RemoteConnection connection;

public InfoBox.from_device (NM.Device device) {
Object (device: device);
Expand Down Expand Up @@ -77,6 +79,21 @@ public class Network.Widgets.InfoBox : Gtk.Box {
xalign = 0
};

reduce_data_switch = new Gtk.Switch () {
valign = CENTER
};

var reduce_data_header = new Granite.HeaderLabel (_("Reduce background data usage")) {
mnemonic_widget = reduce_data_switch,
secondary_text = _("While connected to this network, background tasks like automatic updates will be paused.")
};

var reduce_data_box = new Gtk.Box (HORIZONTAL, 12) {
margin_top = 24
};
reduce_data_box.append (reduce_data_header);
reduce_data_box.append (reduce_data_switch);

orientation = VERTICAL;
append (ip4address_head);
append (ip4address);
Expand All @@ -89,13 +106,48 @@ public class Network.Widgets.InfoBox : Gtk.Box {
append (dns_head);
append (dns);
append (send_receive_box);
append (reduce_data_box);

connection = device.get_active_connection ().connection;
connection.changed.connect (update_settings);

device.state_changed.connect (() => {
update_status ();
info_changed ();
});

update_settings ();
update_status ();

reduce_data_switch.notify["active"].connect (() => {
var setting_connection = connection.get_setting_connection ();
var metered = setting_connection.metered;

if (reduce_data_switch.active && metered != YES && metered != GUESS_YES) {
metered = YES;
} else if (!reduce_data_switch.active && metered != NO && metered != GUESS_NO) {
metered = NO;
}

setting_connection.set_property (NM.SettingConnection.METERED, metered);

try {
connection.commit_changes_async.begin (true, null);
} catch (Error e) {
var message_dialog = new Granite.MessageDialog.with_image_from_icon_name (
_("Failed To Configure Settings"),
_("Unable to save changes to the disk"),
"network-error",
Gtk.ButtonsType.CLOSE
) {
modal = true,
transient_for = (Gtk.Window) get_root ()
};
message_dialog.show_error_details (e.message);
message_dialog.response.connect (message_dialog.destroy);
message_dialog.present ();
}
});
}

public void update_activity (string sent_bytes, string received_bytes) {
Expand Down Expand Up @@ -154,4 +206,10 @@ public class Network.Widgets.InfoBox : Gtk.Box {
update_sidebar (owner);
}
}

private void update_settings () {
var setting_connection = connection.get_setting_connection ();

reduce_data_switch.active = setting_connection.metered == YES || setting_connection.metered == GUESS_YES;
}
}
Loading