Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gitlab-91] Updated flaky tests to always run #42

Merged
merged 7 commits into from
Jan 22, 2025
Merged

[Gitlab-91] Updated flaky tests to always run #42

merged 7 commits into from
Jan 22, 2025

Conversation

dheesen
Copy link
Collaborator

@dheesen dheesen commented Jan 16, 2025

No description provided.

@dheesen dheesen changed the title Updated flaky tests to always run [Gitlab-91] Updated flaky tests to always run Jan 16, 2025
shayfaber
shayfaber requested changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@shayfaber shayfaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looking good! The only change I would request is to update the console.log to a testInfo annotation, I've added some comments to indicate where this could be implemented.

dheesen
dheesen commented Jan 22, 2025
View reviewed changes
Copy link
Collaborator Author

@dheesen dheesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shayfaber Fixed comments!

@dheesen dheesen merged commit 80b6aac into main Jan 22, 2025
1 check failed
@dheesen dheesen deleted the gitlab-91 branch January 22, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shayfaber shayfaber shayfaber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dheesen @shayfaber