#58 Add a pause between each paragraph #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nya-elimu
previously approved these changes
Sep 9, 2021
| private StoryBookChapterGson storyBookChapter; | ||
|
|
||
| protected String chapterText = ""; | ||
| protected String[] chapterText = {}; |
There was a problem hiding this comment.
Perhaps rename to chapterParagraphs?
| @@ -200,7 +199,7 @@ public void onClick(View view) { | |||
| }); | |||
| } | |||
|
|
|||
| public void playAudio(final String chapterText, final AudioListener audioListener) { | |||
| public void playAudio(final String[] chapterText, final AudioListener audioListener) { | |||
| List<StoryBookParagraphGson> storyBookParagraphs = storyBookChapter.getStoryBookParagraphs(); | |||
| StoryBookParagraphGson storyBookParagraphGson = storyBookParagraphs.get(0); | |||
There was a problem hiding this comment.
It looks like we have hardcoded a selection of only the first paragraph, which is probably the audio is not being played correctly for chapters containing more than 1 paragraph.
I created a separate issue for this here: #90
There was a problem hiding this comment.
I'll take that issue
@gscdev Great, thank you! 🙂
| @@ -189,7 +188,7 @@ public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceStat | |||
| super.onViewCreated(view, savedInstanceState); | |||
|
|
|||
| // Add button for initializing Text-to-Speech (TTS) | |||
| final String finalChapterText = chapterText; | |||
| final String[] finalChapterText = chapterText; | |||
There was a problem hiding this comment.
finalChapterText might be mistaken for meaning "the final text of this chapter", so perhaps we should rename this variable?
nya-elimu
previously approved these changes
Sep 10, 2021
| @@ -61,7 +61,7 @@ | |||
|
|
|||
| private StoryBookChapterGson storyBookChapter; | |||
|
|
|||
| protected String[] chapterText = {}; | |||
| protected String[] chapterParagraph = {}; | |||
There was a problem hiding this comment.
And perhaps make the name plural, since it's an array?
Suggested change
| protected String[] chapterParagraph = {}; | |
| protected String[] chapterParagraphs = {}; |
| @@ -54,19 +54,19 @@ public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, | |||
| int[] titleFontSize = getResources().getIntArray(R.array.cover_title_font_size); | |||
| int[] descriptionFontSize = getResources().getIntArray(R.array.chapter_text_font_size); | |||
|
|
|||
| for (int i=0; i<chapterText.length; i++) { | |||
| chapterText[i] = setWordSpacing(chapterText[i]); | |||
| for (int i=0; i<chapterParagraph.length; i++) { | |||
There was a problem hiding this comment.
Suggested change
| for (int i=0; i<chapterParagraph.length; i++) { | |
| for (int i = 0; i < chapterParagraph.length; i++) { |
jo-elimu
previously approved these changes
Sep 10, 2021
gscdev
deleted the
58-Play-chapters-audio-recordings-when-FAB-is-pressed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.