fix: prevent data loss in branch reset with safe clone-then-swap#31
Merged
fix: prevent data loss in branch reset with safe clone-then-swap#31
Conversation
Previously, branch reset would destroy the existing dataset before cloning the new snapshot. If the clone operation failed after the destroy completed, the original dataset would be permanently lost with no recovery path. Now uses a safe clone-then-swap pattern: 1. Clone parent snapshot to temporary dataset 2. Mount temp dataset to verify it works 3. Swap datasets via ZFS rename (original preserved as backup) 4. Clean up backup after successful swap This ensures the original dataset remains intact until the new clone is verified ready. Fixes #21 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renameDataset()method to ZFSManager for safe dataset swapsFixes #21
Test plan
🤖 Generated with Claude Code