Filter client capabilities that can't be met by server #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmach
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #173
Previously, during the initial handshake the library would error if the client and server capabilities didn't match. However, the MySQL spec says the client should simply remove the flags the server can't comply with: https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_connection_phase.html.
It seems this part of the code was reusing a function that tried to ensure all the appropriate auth capabilities were present: https://github.com/elixir-ecto/myxql/blob/master/lib/myxql/protocol.ex#L116.
The change here is to introduce a filtering function instead of using the "ensure everything allowed" function.