Fix socket_options instead using keywork merge, concat default options with assigned options #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with assigned options
josevalim
reviewed
May 18, 2024
lib/myxql/client.ex
Outdated
| @@ -43,8 +47,7 @@ defmodule MyXQL.Client do | |||
| ssl_opts: Keyword.get(opts, :ssl_opts, []), | |||
| connect_timeout: Keyword.get(opts, :connect_timeout, @default_timeout), | |||
| handshake_timeout: Keyword.get(opts, :handshake_timeout, @default_timeout), | |||
| socket_options: | |||
| Keyword.merge([mode: :binary, packet: :raw, active: false], opts[:socket_options] || []), | |||
| socket_options: @sock_opts ++ (opts[:socket_options] || []), | |||
There was a problem hiding this comment.
I think we want the opposite order because what comes first wins. Maybe we can also write a test? You can set socket_options: [:inet] for the test.
There was a problem hiding this comment.
Agreed, I will do that.
josevalim
reviewed
May 18, 2024
josevalim
reviewed
May 18, 2024
josevalim
reviewed
May 18, 2024
josevalim
reviewed
May 18, 2024
josevalim
approved these changes
May 18, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.