Safely convert payloads to strings #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For non-error tuples `Exception.normalize/3` returns the original payload, which may be anything. Some payloads such as tuples don't implement the `String.Chars` protocol. So cally `to_string/1` will fail. In such cases we fall back to `inspect/1`.
crbelaus
force-pushed
the
fix-genserver-timeouts
branch
from
e119149 to
e09ea86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For non-error tuples
Exception.normalize/3returns the original payload, which may be anything. Some payloads such as tuples don't implement theString.Charsprotocol. So callingto_string/1will fail. In such cases we fall back toinspect/1.I made a few updates to the
live.exsscript to reproduce this problem. You can runelixir live.exsand click the button called «GenServer timeout». This will cause an error that should be recorded by the error tracker.If you revert the changes that I made and try this same button you will se that the error payload cannot be converted to string and detaches the ErrorTracker telemetry handler.
Closes #109