-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Use lazy bdd for all types #14806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Use lazy bdd for all types #14806
+271
−292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazy BDDS: ternary trees (instead of binary) where the additional node encodes a lazy union. See "COVARIANCE AND CONTRAVARIANCE: A FRESH LOOK AT AN OLD ISSUE"
Now it only seems to appear in artificial examples.
Remark: best 1.19 performance, similar to 1.18 speed!
💚 💙 💜 💛 ❤️ |
I found an issue when trying this out, here is a repro: Mix.install([:stream_data])
defmodule BrokenBDD do
def type() do
StreamData.one_of([StreamData.integer(), StreamData.binary()])
end
end
Might be able to look into it later, but reporting it for now before I forget 🙂 |
@sabiwara i believe it is a cache issue. You need to purge all cache from archives or previous Mix installs. We can also bump the internal chunk version. |
Yeah you're right, sorry for the false warning 🙇 |
josevalim
added a commit
that referenced
this pull request
Oct 4, 2025
We use Lazy BDDS: ternary trees (instead of binary) where the additional node encodes a lazy union, as in "COVARIANCE AND CONTRAVARIANCE: A FRESH LOOK AT AN OLD ISSUE", with some additional optimisations for intersections and differences to avoid materialising unions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.