Fix inaccurate hint for disabling :test_ignore_filters #14808
Merged
+23
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also like the idea of allowing |
|
💚 💙 💜 💛 ❤️ |
|
Backported, I am prepping a new RC! |
josevalim
pushed a commit
that referenced
this pull request
Oct 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches the docs recommendation: https://hexdocs.pm/mix/1.19.0-rc.0/Mix.Tasks.Test.html.
The current hint ,
test_ignore_filters: false, causes the following error:The second commit provides better feedack is we forget to wrap the config into a list, otherwise it fails later down the line since we build and propagate an improper list. It might be overkill, happy to remove it.
Alternatively, we could use
Enum.concatover++which could be slightly better?To be backported.