Fix typo in load_tokenizer's ArgumentError #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A prior commit 8b52612 removed the concept of tokenizer modules and introduced tokenizer types. As part of the change, the sole expected option for the `load_tokenizer` function was changed from `:module` to `:type`. Unfortunately the commit missed out on changing the error message, which could cause slight confusion amongst devs that use `load_tokenizer` when upgrading bumblebee from pre-v0.5.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A prior commit 8b52612 removed the concept of tokenizer modules and introduced tokenizer types. As part of the change, the sole expected option for the
load_tokenizerfunction was changed from:moduleto:type.Unfortunately the commit missed out on changing the error message, which could cause slight confusion amongst devs that use
load_tokenizerwhen upgrading bumblebee from pre-v0.5.0.