Add Plug.Router tests

[thymusvulgaris]

• Add test that asserts an error is raised with the expected message when Plug.Router.match/3 is not given :to or :do option.

• Add test that asserts an error is raised with the expected message when no routes are defined in a Plug module.

[josevalim]

Thank you. However, I think matching on the error message would be more useful here. The exception class is not that interesting and we may be raising an unrelated error.

[thymusvulgaris]

Thank you. However, I think matching on the error message would be more useful here. The exception class is not that interesting and we may be raising an unrelated error.

Thanks very much for the feedback - does the latest change work?

[thymusvulgaris]

Updated PR description and squashed commits into one commit.

[thymusvulgaris]

Updated test names.

[josevalim]

Hrm, i thought we could use assert_raise to match only on the exception message but it is not possible. So I would use assert_raise/3 still but match on both exception and message. The message being the important one. Sorry for the wrong direction. :)

[thymusvulgaris]

Hrm, i thought we could use assert_raise to match only on the exception message but it is not possible. So I would use assert_raise/3 still but match on both exception and message. The message being the important one. Sorry for the wrong direction. :)

No problem, thanks very much for the clarification.

[josevalim]

💚 💙 💜 💛 ❤️