Plug Debugger add spacing between arguments #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some exceptions can have arguments that are very long when printed out (I'm looking at you
%Plug.Conn{}!):This makes it very difficult to at-a-glance find the second, third, etc arguments (for what it's worth, I find this true in IEx as well). This PR improves this issue by adding some spacing between the arguments so that they stand out more as well as switching the numbers to use the primary color (but with 50% filter applied so it doesn't stick out too much). I like the coloring change because it makes it more clear that the numbers are not part of the exception itself.
Here's the changes:
And here's the first screenshot with the changes: