-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade stream_data #149
Open
milmazz
wants to merge
14
commits into
elixir-toniq:master
Choose a base branch
from
milmazz:m/chore/upgrade-stream-data
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
bd8e5f6
chore: upgrade stream_data
milmazz 8b9034c
reduce duplication on mix.exs
milmazz 651f0ac
fix order error in unit test
milmazz abea59a
bump otp & elixir versions in ci
milmazz 6baaf02
minor updates in GH workflow
milmazz 71c0fa5
revert weird change on mix.exs
milmazz 9a50feb
Follow @mhanberg suggestion to combine otp 25 with elixir 1.13
milmazz f33dead
upgrade all the dependencies
milmazz 698c913
failing tests should pass now
milmazz 1e428d8
upgrade credo config file
milmazz 5aed05d
fix credo findings
milmazz 6ae8792
fix credo consistency findings
milmazz 44d4808
deactivate credo Dbg check, not compat with Elixir v1.13
milmazz 9de8549
keep the same credo checks as before
milmazz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,7 +49,7 @@ defmodule Norm.Core.Selection do | |
defp validate_selectors!([]), do: true | ||
defp validate_selectors!([{_key, inner} | rest]), do: validate_selectors!(inner) and validate_selectors!(rest) | ||
defp validate_selectors!([_key | rest]), do: validate_selectors!(rest) | ||
defp validate_selectors!(other), do: raise ArgumentError, "select expects a list of keys but received: #{inspect other}" | ||
defp validate_selectors!(other), do: raise(ArgumentError, "select expects a list of keys but received: #{inspect other}") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
defp assert_spec!(%Schema{}=schema, key) do | ||
case Schema.key_present?(schema, key) do | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you actually altered the configured checks when you updated the config, do you mind ensuring the same checks enabled as before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated 👍