refactor: reduce imperative shell logic in flake.nix #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhanberg
reviewed
Nov 1, 2023
| name = "7zz-aliased"; | ||
| paths = [pkgs._7zz]; | ||
| postBuild = '' | ||
| ln -s ${pkgs._7zz}/bin/7zz $out/bin/7z |
There was a problem hiding this comment.
Oh heck yeah. I figured there had to be a nix way to do this
mhanberg
reviewed
Nov 2, 2023
|
Works on my x86 Linux and M1 Mac computers, will merge once you revert the bin/7z deletion |
...as their contents are deterministic directly from Nix. Regarding HOME specifically, Burrito.Steps.Build.PackAndBuild seems to want a writable path to work in, but AFAICT it's for scratch space, so we can reuse the Nix build's temporary directory. Ref: https://github.com/burrito-elixir/burrito/blob/a60c6ab21156fc4c788907d33bfd0c546a022272/lib/steps/build/pack_and_build.ex#L26
mhanberg
changed the title
mhanberg
pushed a commit
that referenced
this pull request
Nov 2, 2023
* refactor(nix): Use symlinkJoin to provide aliased 7z binary * refactor(nix): Assign Burrito envvars as derivation arguments ...as their contents are deterministic directly from Nix. Regarding HOME specifically, Burrito.Steps.Build.PackAndBuild seems to want a writable path to work in, but AFAICT it's for scratch space, so we can reuse the Nix build's temporary directory. Ref: https://github.com/burrito-elixir/burrito/blob/a60c6ab21156fc4c788907d33bfd0c546a022272/lib/steps/build/pack_and_build.ex#L26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding
HOMEspecifically, I would've liked to eliminate that too as it's nearly always a pungent smell in Nix builds, but Burrito.Steps.Build.PackAndBuild seems towant a writable path to work in. AFAICT it's purely for scratch space, so we can just directly reuse the Nix build's temporary directory.