Move URI module from ex_ice #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #12 +/- ##
==========================================
+ Coverage 81.73% 85.13% +3.39%
==========================================
Files 15 15
Lines 230 269 +39
==========================================
+ Hits 188 229 +41
+ Misses 42 40 -2
Continue to review full report in Codecov by Sentry.
|
mickel8
force-pushed
the
uri
branch
3 times, most recently
from
b69fcaf to
5379b69
Compare
mickel8
force-pushed
the
uri
branch
4 times, most recently
from
6569246 to
36257c5
Compare
LVala
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URI module is needed both in
ex_iceandex_turn, hence moving toex_stun.This PR also adds support for TURN URIs as specified in RFC 7065, and cleans up tests.