-
Notifications
You must be signed in to change notification settings - Fork 3
Feature/reinstate #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matthappens
wants to merge
10
commits into
ella:master
Choose a base branch
from
whalerock:feature/reinstate
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1afbc04
Added edit timer to FlatComments. By default, users have 15 minutes from
0fd58d1
Checking whether edit timer is enabled in settings or not.
15a0222
Merge 'ella/master' into 'WhiskeyMedia/master'
kvbik 2e01355
Accounting for modules deprecated in Django 1.6, trying to be backwar…
c0ed389
Merge pull request #1 from WhiskeyMedia/django16
honzakral 6897ddc
Create circle.yml
colony005 fba7b91
adding comment reinstate methods
matthappens ce623b2
added submit_date to unsaved FlatComments in order to make it possibl…
matthappens 4910ef2
cleaning up, removing redundant import to ella timezone utils
matthappens f37879d
using ella timezone utils, shifting comment edit settings to ella fla…
matthappens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| checkout: | ||
| post: | ||
| - git submodule sync | ||
| - git submodule update --init | ||
| - git clone git@github.com:WhiskeyMedia/scout.git scout.git | ||
| dependencies: | ||
| override: | ||
|
|
||
| cache_directories: | ||
| - venv/src | ||
| - ~/.pip/cache | ||
| test: | ||
| override: | ||
| # - python setup.py test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this returning a string? what possible use case is there? Return a datetime and use regular methods for rendering it as text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the utility of returning this as a string. I'm also unable to find any other code that consumes the 'get_remaining_edit_time' function. I'll see if I can track down the original author and figure out the reasoning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in that case just remove it, we can add it later if we find we need it - the less code the better :)