Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify getting protocol agnostic hostname #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

michalkleiner
Copy link

@michalkleiner michalkleiner commented Jun 30, 2023

The private method isn't really needed as it's not used anywhere else in the class and a one liner can be used instead.

@Firesphere
Copy link
Contributor

But what's the use of it?
Speed wise, it's barely a difference, and it's only on write on SiteConfig, so it's not anything of any performance improvement to actual visitors.
It reduces readability of the code, with only a very, very minor speed improvement...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants