Change user sort key and improve /peek
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve `/peek` by displaying users who have not nominated any films yet. This is part of the way to moving all the information in `/naughty` to `/peek`. In order to support this, we need to be able to query the film name and vote count by user. We probably should be duplicating this information into the user record, which is the noSQL way. However, if we change the sort key for users from `USER#` to `DISCORDUSER#`, then we are able to grab all users and `FILM#NOMINATION#` entries with one query because they would be next to each other alphabetically. In an unrelated change - that really should be a separate change - we fix some of the `datetime` imports that no longer work on Python 3.9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve
/peekby displaying users who have not nominated any films yet. This is part of the way to moving all the information in/naughtyto/peek.In order to support this, we need to be able to query the film name and vote count by user. We probably should be duplicating this information into the user record, which is the noSQL way. However, if we change the sort key for users from
USER#toDISCORDUSER#, then we are able to grab all users andFILM#NOMINATION#entries with one query because they would be next to each other alphabetically.In an unrelated change - that really should be a separate change - we fix some of the
datetimeimports that no longer work on Python 3.9.