Skip to content

fix: vulnerability on add subscription endpoint #991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ellite merged 1 commit into from
Feb 10, 2026
+51 −39
Merged

fix: vulnerability on add subscription endpoint #991

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 49 additions & 37 deletions endpoints/subscription/add.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,56 +26,68 @@ function validateFileExtension($fileExtension)

function getLogoFromUrl($url, $uploadDir, $name, $settings, $i18n)
{
if (!filter_var($url, FILTER_VALIDATE_URL) || !preg_match('/^https?:\/\//i', $url)) {
$response = [
"success" => false,
"message" => "Invalid URL format."
];
echo json_encode($response);
exit();
}
$maxRedirects = 3;
$currentUrl = $url;

$host = parse_url($url, PHP_URL_HOST);
$ip = gethostbyname($host);
if (filter_var($ip, FILTER_VALIDATE_IP, FILTER_FLAG_NO_PRIV_RANGE | FILTER_FLAG_NO_RES_RANGE) === false) {
$response = [
"success" => false,
"message" => "Invalid IP Address."
];
echo json_encode($response);
exit();
}
for ($i = 0; $i <= $maxRedirects; $i++) {
if (!filter_var($currentUrl, FILTER_VALIDATE_URL) || !preg_match('/^https?:\/\//i', $currentUrl)) {
$response = ["success" => false, "message" => "Invalid URL format."];
echo json_encode($response);
exit();
}

$ch = curl_init($url);
curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
curl_setopt($ch, CURLOPT_TIMEOUT, 5);
curl_setopt($ch, CURLOPT_FOLLOWLOCATION, true);
curl_setopt($ch, CURLOPT_MAXREDIRS, 3);
$parts = parse_url($currentUrl);
$host = $parts['host'];
$port = $parts['port'] ?? ($parts['scheme'] === 'https' ? 443 : 80);
$ip = gethostbyname($host);

$imageData = curl_exec($ch);
if (filter_var($ip, FILTER_VALIDATE_IP, FILTER_FLAG_NO_PRIV_RANGE | FILTER_FLAG_NO_RES_RANGE) === false) {
$response = ["success" => false, "message" => "Invalid IP Address."];
echo json_encode($response);
exit();
}

if ($imageData !== false) {
$timestamp = time();
$fileName = $timestamp . '-' . sanitizeFilename($name) . '.png';
$uploadDir = '../../images/uploads/logos/';
$uploadFile = $uploadDir . $fileName;
$ch = curl_init($currentUrl);
curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
curl_setopt($ch, CURLOPT_TIMEOUT, 5);
curl_setopt($ch, CURLOPT_FOLLOWLOCATION, false);

curl_setopt($ch, CURLOPT_RESOLVE, ["$host:$port:$ip"]);

if (saveLogo($imageData, $uploadFile, $name, $settings)) {
curl_close($ch);
return $fileName;
} else {
echo translate('error_fetching_image', $i18n) . ": " . curl_error($ch);
$imageData = curl_exec($ch);
$httpCode = curl_getinfo($ch, CURLINFO_HTTP_CODE);

if ($httpCode >= 300 && $httpCode < 400) {
$redirectUrl = curl_getinfo($ch, CURLINFO_REDIRECT_URL);
curl_close($ch);
return "";

if (!$redirectUrl) {
break;
}

$currentUrl = $redirectUrl;
continue;
}

if ($imageData !== false && $httpCode === 200) {
$timestamp = time();
$fileName = $timestamp . '-' . sanitizeFilename($name) . '.png';
$uploadDir = '../../images/uploads/logos/';
$uploadFile = $uploadDir . $fileName;

if (saveLogo($imageData, $uploadFile, $name, $settings)) {
curl_close($ch);
return $fileName;
}
}

} else {
echo translate('error_fetching_image', $i18n) . ": " . curl_error($ch);
curl_close($ch);
return "";
}
}

return "";
}

function saveLogo($imageData, $uploadFile, $name, $settings)
{
Expand Down
2 changes: 1 addition & 1 deletion includes/version.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<?php
$version = "v4.6.0";
$version = "v4.6.1";
?>
2 changes: 1 addition & 1 deletion settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,7 +718,7 @@ class="thin mobile-grow" />
<section class="account-notifications-section">
<header class="account-notification-section-header" onclick="openNotificationsSettings('serverchan');">
<h3>
<i class="fa-solid fa-angle-right"></i>
<i class="fa-solid fa-code"></i>
<?= translate('serverchan', $i18n) ?>
</h3>
</header>
Expand Down