Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start RPC server when starting backend #14

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Start RPC server when starting backend #14

merged 1 commit into from
Aug 22, 2024

Conversation

mufeez-amjad
Copy link
Contributor

Uses the RPC server defined in the proto crate in server.

shrenikbhatt
shrenikbhatt approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@shrenikbhatt shrenikbhatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I think eventually we spawn thread for rpc server too and have main join on both

@mufeez-amjad mufeez-amjad merged commit 9409cb9 into main Aug 22, 2024
1 check passed
@mufeez-amjad mufeez-amjad deleted the mufeez/start-rpc-server branch August 22, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrenikbhatt shrenikbhatt shrenikbhatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mufeez-amjad @shrenikbhatt