Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add span_id to TestExecutionRequest proto #15

Merged
merged 1 commit into from
Aug 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion proto/src/definitions/ollyllm/v1/test.proto
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@ message VersionedTest {

/* TestExecutionRequest represents a request to execute a versioned test. */
message TestExecutionRequest {
int32 session_id = 1; // ID of trace session
string span_id = 1; // The associated Span ID for this test (if any).
VersionedTest versioned_test = 2; // Unique test
repeated bytes test_input = 3; // List of parameters for test
google.protobuf.Timestamp request_timestamp = 4; // Client request time of test execution
}

2 changes: 1 addition & 1 deletion proto/src/examples/dummy_client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ impl Client {
) -> Result<tonic::Response<()>, tonic::Status> {
let test_request: tonic::Request<TestExecutionRequest> =
tonic::Request::new(TestExecutionRequest {
session_id: 1,
span_id: "12345abcd".to_string(),
versioned_test: Some(VersionedTest {
name: "no_capitals".to_string(),
version: 1,
Expand Down
Loading