[Kafka] Setup client with examples #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrenikbhatt
force-pushed
the
shrenik/setup-kafka-client
branch
from
70ac057 to
2535cb9
Compare
mufeez-amjad
approved these changes
Aug 28, 2024
kafka/src/example/run_consumer.rs
Outdated
| .try_for_each(|borrowed_message| async move { | ||
| match borrowed_message.payload_view::<str>() { | ||
| Some(Ok(s)) => { | ||
| println!("Recevied payload: {}", s); |
There was a problem hiding this comment.
Suggested change
| println!("Recevied payload: {}", s); | |
| println!("Received payload: {}", s); |
kafka/src/kafka_client.rs
Outdated
Comment on lines
18
to
23
| bootstrap_server: &str, | ||
| group_id: Option<&str>, | ||
| batch_interval: Option<&str>, |
There was a problem hiding this comment.
can we document these parameters?
kafka/src/kafka_client.rs
Outdated
Comment on lines
36
to
37
| let producer: FutureProducer = FutureProducer::from_config(&self.client_config)?; | ||
| Ok(producer) |
There was a problem hiding this comment.
Suggested change
| let producer: FutureProducer = FutureProducer::from_config(&self.client_config)?; | |
| Ok(producer) | |
| FutureProducer::from_config(&self.client_config) |
will this work? same with create_consumer
|
|
||
| pub async fn send_to_topic( | ||
| &self, | ||
| future_producer: &FutureProducer, |
There was a problem hiding this comment.
I wonder if it's worth defining our own wrapper around FutureProducer, for a friendlier type (we control what is created/used based on KafkaClient).
just a general thought
shrenikbhatt
force-pushed
the
shrenik/setup-kafka-client
branch
from
2535cb9 to
b599099
Compare
shrenikbhatt
force-pushed
the
shrenik/setup-kafka-client
branch
from
b599099 to
25cc20f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards https://linear.app/ollm/issue/OLL-20/kafka-spin-up