Add pipeline to validate that tree-sitter changes works with language server #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qluxzz
commented
Dec 20, 2023
| cd elm-language-server/ | ||
| npm i | ||
| npm run compile | ||
| npm install -g elm-format |
There was a problem hiding this comment.
@razzeee I saw that this was done in the elm-language-server test pipeline as well, but I'm just wondering if it wouldn't be better to add elm-format to the devDependencies for elm-language-server.
Currently if you checkout the elm-language-server repo and try to run the test suite without having elm-format installed globally, the test in test/diff.test.ts fails.
There was a problem hiding this comment.
I'm actually unsure, has been some time since we looked at this and the binary is not exactly the same thing as the node dependency if I remember correctly, it has different performance etc.
It might work fine, if it's only for the tests though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally posted by @razzeee in #144 (comment)
I thought it was a good idea to create a pipeline in this repo that could validate that all tests in elm-language-server works with the updated wasm bundle before allowing the changes to be merged.