add 600 font weight for Source Code Pro to import #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #221 for details
add BrianHicks/elm-benchmark to native whitelist
Documentation text with styles "font-family : 'Source Code Pro'" and "font-weight: bold" renders poorly. Importing both the 400 and 600 weight styles from Google Fonts fixes this.
|
Thanks for the pull request! Make sure it satisfies this checklist. My human colleagues will appreciate it! Here is what to expect next, and if anyone wants to comment, keep these things in mind. |
|
Your including more then just your changes here. Probably a rebase error. |
|
Isn't bold 700? I believe that 600 is semi-bold in Source Code Pro, could you show an example where semi-bold is used in the documentation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation text with styles "font-family : 'Source Code Pro'" and "font-weight: bold" renders poorly. Importing both the 400 and 600 weight styles from Google Fonts fixes this.