-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] cannot end a flowchart when a End is Then Activity in If #5899
base: main
Are you sure you want to change the base?
Conversation
Send BreakSignal when executing End Activity
Check isBreaking when a child completed in Flowchart
@dotnet-policy-service agree |
Add test case of Breaking from a While which includes a Flowchart
Add test case of ending a flowchart when the end activity is nested in a If.
Add test case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense. Only thing I'm unsure of is whether we should reuse the BreakSignal
, or if it would be better to create a dedicated EndSignal
. The former is intended to break out of a "scope" such as a for-each activity's Body, while the latter would be intended to complete the closest flowchart activity containing the End activity.
Thoughts?
Good idea! The |
Now the |
Yes, the |
@sfmskywalker Hi. Any thoughts about this pr? |
fix #5823
Welcome to post suggestions.
This change is