Skip to content

FEAT : Connection/Secret provider/handler to define generic configuration for Activities #6291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 23, 2025

Conversation

jdevillard
Copy link
Contributor

@jdevillard jdevillard commented Jan 13, 2025

This PR is a first proposition about the features #6230.

The aim is to provide an easy way to :

  • allow user to define in a repository a complex object regarding the configuration of an activity (for example , a connection that use userAccount, userKey, Url which can be reuse for multiple activities.
  • map the complex object to the properties of the activity (to allow the dev to retrieve and use the different values)

The configuration is done using a repository which can be implementing using a keyvault or other.
The mapping is done using a middleware before the execution of the activity.
The configuration need then some screens and UI Hint to be configured in the Elsa.Studio.

For now the items available are :

  • InMemory repository implementation
  • mapping middleware
  • basic CRUD api
  • Database repository
  • SQLite implementation
  • other database implementation
  • refresh configuration notification

A link to the Studio PR will be add once available.


This change is Reviewable

@jdevillard jdevillard added the enhancement New feature or request label Jan 13, 2025
@jdevillard jdevillard force-pushed the enh/Connections branch 3 times, most recently from 8df635c to fe83739 Compare January 14, 2025 12:29
- Refactor IStore, InputModel and Entities
- Add Persistence Project
- Add EntityFameworkCore Project
Add Get Endpoints
Add entity framework Core  feature SqlLite implementation
@jdevillard jdevillard marked this pull request as ready for review February 12, 2025 22:59
jdevillard and others added 4 commits February 14, 2025 22:12
Added new Connections modules to the solution and updated project references to include necessary dependencies. Also modified DictionaryExtensions to return null as the default value instead of default. Removed an unused JavaScript helper import to streamline the code.
Removed unused code, optimized imports, and updated method signatures for better null-safety and consistency. Consolidated redundant logic, improved error handling in endpoints, and applied modern syntax and practices across the Connections module.
@sfmskywalker sfmskywalker merged commit 6f5b7e7 into elsa-workflows:main Feb 23, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants