-
Notifications
You must be signed in to change notification settings - Fork 1.3k
FEAT : Connection/Secret provider/handler to define generic configuration for Activities #6291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sfmskywalker
merged 12 commits into
elsa-workflows:main
from
jdevillard:enh/Connections
Feb 23, 2025
Merged
FEAT : Connection/Secret provider/handler to define generic configuration for Activities #6291
sfmskywalker
merged 12 commits into
elsa-workflows:main
from
jdevillard:enh/Connections
Feb 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of options in inherited class. clean ConnectionOptionsProvider class
8df635c
to
fe83739
Compare
fe83739
to
5e6acc0
Compare
sfmskywalker
approved these changes
Feb 6, 2025
- Refactor IStore, InputModel and Entities - Add Persistence Project - Add EntityFameworkCore Project
Add Get Endpoints Add entity framework Core feature SqlLite implementation
Added new Connections modules to the solution and updated project references to include necessary dependencies. Also modified DictionaryExtensions to return null as the default value instead of default. Removed an unused JavaScript helper import to streamline the code.
Removed unused code, optimized imports, and updated method signatures for better null-safety and consistency. Consolidated redundant logic, improved error handling in endpoints, and applied modern syntax and practices across the Connections module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first proposition about the features #6230.
The aim is to provide an easy way to :
The configuration is done using a repository which can be implementing using a keyvault or other.
The mapping is done using a middleware before the execution of the activity.
The configuration need then some screens and UI Hint to be configured in the Elsa.Studio.
For now the items available are :
A link to the Studio PR will be add once available.
This change is