Fix shell feature discovery and remove duplicate service registrations

[Copilot]

Addresses review feedback from #7279 to fix runtime DI failures and improve shell feature system integrity.

Feature Discovery

Added missing [ShellFeature] attributes to 7 features (Mediator, Multitenancy, SystemClock, DefaultFormatters, StringCompression, CommitStrategies, Expressions). Without these attributes, CShells cannot resolve DependsOn references, causing runtime failures.

Duplicate Registration Fixes

• Caching: Removed caching service registrations from WorkflowManagementFeature and WorkflowRuntimeFeature — moved exclusively to CachingWorkflowDefinitionsFeature and CachingWorkflowRuntimeFeature to prevent double-decoration
• Recurring tasks: Removed conflicting TriggerBookmarkQueueRecurringTask schedule (10s vs 1m)
• Runtime services: Removed duplicate WorkflowResumer and BookmarkQueueWorker registrations
• JavaScript: Removed duplicate ITypeDefinitionService registration
• Flowchart: Removed registrations from WorkflowsFeature (already in FlowchartFeature)

Security & Compatibility

• Removed hard-coded signing key from IdentityFeature — must be configured by application to prevent token forgery
• Fixed null-safety in BlobStorageFeature.GetDefaultWorkflowsDirectory using AppContext.BaseDirectory fallback
• Registered IInstalledFeatureProvider in legacy module system for API endpoint compatibility
• Fixed XML doc mismatch in PersistenceShellFeatureBase (Scoped vs Singleton)

Cleanup

Removed commented-out CShells.Abstractions package references from Elsa.Common and Elsa.Workflows.Core projects.

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

[greptile-apps]

Greptile Overview

Greptile Summary

This PR addresses critical runtime DI failures and improves the shell feature system integrity by adding missing [ShellFeature] attributes and removing duplicate service registrations.

Key Changes:

• Added [ShellFeature] attributes to 7 features (Mediator, Multitenancy, SystemClock, DefaultFormatters, StringCompression, CommitStrategies, Expressions) to enable CShells dependency resolution via DependsOn references
• Removed duplicate caching service registrations from WorkflowManagementFeature and WorkflowRuntimeFeature - these are now exclusively handled by CachingWorkflowDefinitionsFeature and CachingWorkflowRuntimeFeature
• Fixed conflicting TriggerBookmarkQueueRecurringTask schedule (removed 10-second schedule, keeping 1-minute schedule)
• Removed duplicate WorkflowResumer and BookmarkQueueWorker registrations in WorkflowRuntimeFeature
• Removed duplicate ITypeDefinitionService registration from JavaScriptFeature
• Moved Flowchart service registrations from WorkflowsFeature to dedicated FlowchartFeature
• Removed hard-coded signing key from IdentityFeature - applications must now configure this explicitly for security
• Fixed null-safety in BlobStorageFeature.GetDefaultWorkflowsDirectory using AppContext.BaseDirectory fallback
• Registered IInstalledFeatureProvider in legacy module system for API endpoint compatibility
• Fixed XML doc mismatch in PersistenceShellFeatureBase
• Cleaned up commented-out package references

The changes are well-structured and follow proper separation of concerns by moving duplicate registrations to dedicated feature modules.

Confidence Score: 4/5

• This PR is generally safe to merge with one important consideration regarding the signing key change
• The changes are well-focused on fixing DI issues and reducing duplication. Most changes are straightforward attribute additions and service registration removals. The main concern is the IdentityFeature signing key removal, which is a breaking change that requires applications to explicitly configure the signing key - this improves security but may break existing deployments if not documented properly
• Pay close attention to src/modules/Elsa.Identity/ShellFeatures/IdentityFeature.cs - the signing key removal is a breaking change that requires migration steps for existing applications

Important Files Changed

Filename	Overview
src/common/Elsa.Features/Implementations/Module.cs	Added IInstalledFeatureProvider registration for API endpoint compatibility with legacy module system
src/modules/Elsa.Identity/ShellFeatures/IdentityFeature.cs	Removed hard-coded signing key default value; applications must now configure SigningKey explicitly to prevent security issues
src/modules/Elsa.WorkflowProviders.BlobStorage/ShellFeatures/BlobStorageFeature.cs	Fixed null-safety: now uses AppContext.BaseDirectory fallback when Assembly.GetEntryAssembly() returns null
src/modules/Elsa.Workflows.Management/ShellFeatures/WorkflowManagementFeature.cs	Removed caching service registrations and decorators (moved to CachingWorkflowDefinitionsFeature)
src/modules/Elsa.Workflows.Runtime/ShellFeatures/WorkflowRuntimeFeature.cs	Removed conflicting recurring task schedule, duplicate WorkflowResumer and BookmarkQueueWorker registrations, and caching decorators (moved to CachingWorkflowRuntimeFeature)

Sequence Diagram

sequenceDiagram
    participant App as Application Startup
    participant Module as Module System
    participant WM as WorkflowManagementFeature
    participant WR as WorkflowRuntimeFeature
    participant CWD as CachingWorkflowDefinitionsFeature
    participant CWR as CachingWorkflowRuntimeFeature
    participant Shell as Shell Features (7 new attributes)

    Note over App,Shell: Before PR: Duplicate Registrations
    App->>Module: Configure Features
    Module->>WM: ConfigureServices()
    WM->>WM: Register IWorkflowDefinitionStore
    WM->>WM: Register Caching Decorators ❌
    Module->>WR: ConfigureServices()
    WR->>WR: Register WorkflowResumer (twice) ❌
    WR->>WR: Register BookmarkQueueWorker (twice) ❌
    WR->>WR: Configure TriggerBookmarkQueue (10s) ❌
    WR->>WR: Register TriggerBookmarkQueue (1m) ❌
    WR->>WR: Register Caching Decorators ❌

    Note over App,Shell: After PR: Clean Separation
    App->>Module: Configure Features
    Module->>Shell: Resolve DependsOn references ✓
    Shell->>Shell: ShellFeature attributes enable resolution
    Module->>WM: ConfigureServices()
    WM->>WM: Register IWorkflowDefinitionStore only ✓
    Module->>CWD: ConfigureServices()
    CWD->>CWD: Register Caching Decorators ✓
    Module->>WR: ConfigureServices()
    WR->>WR: Register WorkflowResumer (once) ✓
    WR->>WR: Register BookmarkQueueWorker (once) ✓
    WR->>WR: Register TriggerBookmarkQueue (1m) ✓
    Module->>CWR: ConfigureServices()
    CWR->>CWR: Register Caching Decorators ✓

Loading

[greptile-apps]

_{17 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

Breaking change - existing applications using IdentityFeature will need to explicitly configure the SigningKey in their startup code, otherwise token generation/validation will fail at runtime. Consider documenting migration steps.