Skip to content

Add missing AggregateFaultCount column to V3_7 migration #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sfmskywalker merged 2 commits into from
Feb 5, 2026
Merged

Add missing AggregateFaultCount column to V3_7 migration #120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
658406f
Initial plan
Copilot Feb 5, 2026
22ee420
Add missing AggregateFaultCount column to migration
Copilot Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/modules/persistence/Elsa.Persistence.Dapper.Migrations/Runtime/V3_7.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ public override void Up()
Alter.Table("ActivityExecutionRecords").AddColumn("SchedulingActivityId").AsString().Nullable();
Alter.Table("ActivityExecutionRecords").AddColumn("SchedulingWorkflowInstanceId").AsString().Nullable();
Alter.Table("ActivityExecutionRecords").AddColumn("CallStackDepth").AsInt32().Nullable();
Alter.Table("ActivityExecutionRecords").AddColumn("AggregateFaultCount").AsInt32().NotNullable().WithDefaultValue(0);
Copy link

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AggregateFaultCount column was already added to the ActivityExecutionRecords table in the V3_5 migration (line 17 of V3_5.cs). Adding it again in V3_7 will cause migration failures because the column already exists. This line should be removed.

Copilot uses AI. Check for mistakes.
}

/// <inheritdoc />
Expand All @@ -29,5 +30,6 @@ public override void Down()
Delete.Column("SchedulingActivityId").FromTable("ActivityExecutionRecords");
Delete.Column("SchedulingWorkflowInstanceId").FromTable("ActivityExecutionRecords");
Delete.Column("CallStackDepth").FromTable("ActivityExecutionRecords");
Delete.Column("AggregateFaultCount").FromTable("ActivityExecutionRecords");
Copy link

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This deletion should be removed because the AggregateFaultCount column was already added in the V3_5 migration, not V3_7. The V3_5 Down() method is responsible for removing this column.

Copilot uses AI. Check for mistakes.
}
}
Loading