fix: should not replace literal + with a space in the query string
#960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macabeus
changed the title
+ with in the query string+ with a space in the query string
macabeus
commented
Dec 22, 2024
src/compose.ts
Outdated
| if(memory === -1) temp = url.slice(start).replace(/\\+|%20/g, ' ') | ||
| else temp = url.slice(start, memory).replace(/\\+|%20/g, ' ') | ||
| if(memory === -1) temp = url.slice(start) | ||
| else temp = url.slice(start, memory) |
There was a problem hiding this comment.
We don't need to replace %20 with space because we are already calling decodeURIComponent earlier.
macabeus
commented
Dec 22, 2024
src/compose.ts
Outdated
| @@ -694,7 +692,7 @@ export const composeHandler = ({ | |||
| }` | |||
| } else { | |||
| fnLiteral += `if(c.qi !== -1) { | |||
| let url = '&' + decodeURIComponent(c.url.slice(c.qi + 1)) | |||
| let url = '&' + decodeURIComponent(c.url.slice(c.qi + 1).replaceAll('+', ' ')) | |||
There was a problem hiding this comment.
We should replace + with a space before calling decodeURIComponent.
Otherwise, we won't know whether a + comes from a space (and we want to replace it with space) or comes from a %2B (and we want to keep it).
macabeus
force-pushed
the
fix-issue-943
branch
from
0d8db6e to
06858c2
Compare
macabeus
force-pushed
the
fix-issue-943
branch
from
06858c2 to
36e2b83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #943, in which a literal
+from the query string is replaced with a space.