Always update status if search process ends #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the search process ends with a non-zero exit code, the helm status was never updated. E.g. Grep, Ripgrep and likely more use exit code 1 to indicate that nothing is found, a frequently occurring scenario that left the user wondering if the process is still searching or not. Now it will always update status if the process is not live anymore.
Azkae
added a commit
to Azkae/emacs-helm-ag
that referenced
this pull request
Nov 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the search process ends with a non-zero exit code, the helm status was never updated. E.g. Grep, Ripgrep and likely more use exit code 1 to indicate that nothing is found, a frequently occurring scenario that left the user wondering if the process is still searching or not.
Now it will always update status if the process is not live anymore.
Fixes #251 (not by adding a waiting status as suggested, but clearly indicating the finished status)