Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix embassy-time doc #3778

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Conversation

HaoboGu
Copy link
Contributor

@HaoboGu HaoboGu commented Jan 16, 2025

Current doc says if there's If no generic-queue-* feature is enabled, a default of 64 timers is used. But according to:

#[cfg(feature = "_generic-queue")]
pub mod queue_generic;
#[cfg(not(feature = "_generic-queue"))]
pub mod queue_integrated;
#[cfg(feature = "_generic-queue")]
pub use queue_generic::Queue;
#[cfg(not(feature = "_generic-queue"))]
pub use queue_integrated::Queue;

the queue_integrated::Queue is used in this case. So the default 64 timers actually do nothing:

#[cfg(not(any(
feature = "generic-queue-8",
feature = "generic-queue-16",
feature = "generic-queue-32",
feature = "generic-queue-64",
feature = "generic-queue-128"
)))]
const QUEUE_SIZE: usize = 64;

Signed-off-by: Haobo Gu <haobogu@outlook.com>
@Dirbaio Dirbaio added this pull request to the merge queue Jan 21, 2025
Merged via the queue into embassy-rs:main with commit cf05aa5 Jan 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants