BufferedUart initialization #3983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lulf
reviewed
Mar 20, 2025
|
I'll knock that out later today! |
|
I think this is ready now - I really need to learn how to script builds for all the example architectures, I was just letting CI catch failures as I went on. 😅 |
|
Thanks! Could you rebase this please? |
mgomez0
force-pushed
the
topic/buffered-uart-take-pins-before-interrupts
branch
from
1193320 to
6c9b82f
Compare
|
@lulf good to go. |
|
Could you also squash these commits? I guess this will break the API for lots of people, so it's worth adding a note to the changelogs for each HAL as well I think. |
mgomez0
force-pushed
the
topic/buffered-uart-take-pins-before-interrupts
branch
from
ff16fe2 to
b9332ed
Compare
This change modifies UART initialization throughout Embassy to take pins before interrupts. Related to embassy-rs#1304.
mgomez0
force-pushed
the
topic/buffered-uart-take-pins-before-interrupts
branch
from
b9332ed to
f1feedf
Compare
|
@lulf squashed commits and added notes to changelogs. |
|
Thanks! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies BufferedUart new() and new_with_rtscts() to take pins before interrupts at initialization.
Related to #1304.