Starting Domain layer#16
Closed
lyzlovazlata wants to merge 5 commits intoembedded-dev-research:mainfrom
Closed
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| folderId: String, | ||
| noteId: String, | ||
| ) { | ||
| val folder = folderRepo.getFolderById(folderId) ?: throw IllegalArgumentException("Folder not found: $folderId") |
Check warning
Code scanning / detekt
Property is unused and should be removed.
| override suspend fun renameFolder( | ||
| id: String, | ||
| name: String, | ||
| ) {} |
Check warning
Code scanning / detekt
Empty block of code detected. As they serve no purpose they should be removed.
| name: String, | ||
| ) {} | ||
|
|
||
| override suspend fun deleteFolder(id: String) {} |
Check warning
Code scanning / detekt
Empty block of code detected. As they serve no purpose they should be removed.
|
|
||
| override suspend fun getFolderById(id: String): NoteFolder? = store[id] | ||
|
|
||
| override suspend fun updateFolder(folder: NoteFolder) {} |
Check warning
Code scanning / detekt
Empty block of code detected. As they serve no purpose they should be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add 2 models: Note, Note folder
Add 2 interfaces of repository: Note Repository, Folder Repository - should have realisation in Data layer
Add Use cases for both entities (will be expanded)
Add tests for models and use cases (will be expanded)