-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to glimmer components #685
Conversation
@ef4 have you any time for review? If no, so i will merge it and make a release. So the consumer app can report additional problems which were not detected with tests / docs page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, overall looks good.
I didn't have a change to try running this in an app, but as long as you're available to deal with any followup issues, this is ready to go.
Changes
classic
components are nowglimmer
componentsliquid-if
,liquid-bind
,liquid-outlet
dosn't have anymore position paramenters (not supported by glimmer components)mixins
were removedLiquidVersions
has new parameter (@containerElement
). This is necessary, because there was used an internal, depreacted property from classic components (nearestWithProperty
) to detect the nearestliquid-child
element. The paramter must be passed when the consumer app is usingLiquidContainer
or when the app has used@containerless
as paramenter for any liquid componentThis changes are braking and makes part of addonV2 switch (#681)