Skip to content

Commit

Permalink
Tested ember-intl compatibility (#106)
Browse files Browse the repository at this point in the history
* chore: Tested compatibilities with ember-intl@v6 and ember-intl@v7

* chore: Added lockfile

* chore: Added changeset

---------

Co-authored-by: ijlee2 <ijlee2@users.noreply.github.com>
  • Loading branch information
ijlee2 and ijlee2 authored Jul 10, 2024
1 parent 9eb0dcd commit 0c9ccb1
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 19 deletions.
5 changes: 5 additions & 0 deletions .changeset/nasty-fireants-prove.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@ember-intl/cp-validations": patch
---

Tested compatibilities with ember-intl@v6 and ember-intl@v7
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ jobs:
fail-fast: false
matrix:
scenario:
- 'ember-intl-6'
- 'ember-lts-3.28'
- 'ember-lts-4.12'
- 'ember-lts-5.4'
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ Adds support for [ember-intl](https://github.com/yahoo/ember-intl) in ember-cp-v
* Ember.js v3.28 or above
* Node.js v18 or above
* `ember-cp-validations` v6
* `ember-intl` v6
* `ember-intl` v6 or above

## Installation

Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"ember-cli-sri": "^2.1.1",
"ember-cli-terser": "^4.0.2",
"ember-cp-validations": "^6.0.1",
"ember-intl": "^6.1.0",
"ember-intl": "^7.0.4",
"ember-load-initializers": "^2.1.2",
"ember-page-title": "^8.2.3",
"ember-qunit": "^8.0.2",
Expand All @@ -84,7 +84,7 @@
},
"peerDependencies": {
"ember-cp-validations": "^6.0.0",
"ember-intl": "^6.1.0"
"ember-intl": "^6.1.0 || ^7.0.0"
},
"peerDependenciesMeta": {
"ember-intl": {
Expand Down
25 changes: 9 additions & 16 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions tests/dummy/config/ember-try.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,16 @@ module.exports = async function () {
return {
usePnpm: true,
scenarios: [
{
name: 'ember-intl-6',
npm: {
devDependencies: {
'ember-intl': await latestVersion('ember-intl', {
version: '6',
}),
},
},
},
{
name: 'ember-lts-3.28',
npm: {
Expand Down

0 comments on commit 0c9ccb1

Please sign in to comment.