Fix parsing error when in-tag string content contains >
#996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch inside string attribute or arg to helper in MustacheStatement node
rgallagherab
commented
Jul 18, 2024
| @@ -513,7 +513,10 @@ export default class ParseResult { | |||
| blockParamsEndIndex + 1 | |||
| ); | |||
|
|
|||
| const closeOpenIndex = nodeInfo.source.indexOf(selfClosing ? '/>' : '>'); | |||
| // Match closing index after start of block params to avoid closing tag if /> or > encountered in string | |||
There was a problem hiding this comment.
I'm assuming that since this is inside of an if statement for when block params are present we can trust that the closing bracket will never be before the starting index of the block param and any strings for attributes or helper args will always be before this index.
lifeart
approved these changes
Jul 18, 2024
NullVoxPopuli
approved these changes
Jul 24, 2024
|
Can you add a descriptive PR title? |
bmish
changed the title
>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue where an
ElementNodewith block params can be prematurely terminated if a right angle bracket (>) is included in a string before the true closing bracket.fixes #995