Conversation
|
This looks like a good start covering the ECMA globals. Perhaps we also care about some WHATWG globals: https://html.spec.whatwg.org/multipage/nav-history-apis.html#window I think it's fine to be choosy, there is definitely stuff in there that is pretty much legacy (like |
|
oooo, ya good thinking. doing |
|
done! |
|
CI fixes extracted to #71 |
2388d34 to
7e23656
Compare
|
@NullVoxPopuli @ef4 any feeling on what the impact of this change is? it feels like it's kinda breaking but not really in a way that should be exposed to the end user 🤔 |
|
it's 100% non-breaking, because if you tried to use a global before this PR, you'd just have an error. |
|
Correct, it's not breaking. |
RFC: emberjs/rfcs#1070