Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting primary GID for users to be created from config. #89

Merged
merged 2 commits into from
Sep 30, 2023

Conversation

MrDonkey07
Copy link
Contributor

Setting primary GID for users to be created from config.

Rather than creating default individual groups for each user when calling useradd, the specified GID for that user will be used as the user's primary group. This ensures that files created by that user inside the container are correctly owned by the specified host GID.

@winromulus
Copy link
Contributor

I'm going to keep this open for a bit because:

  1. I don't have a stable dev environment right now
  2. The pipeline is dependent on some secrets and need to refactor that one first
  3. This requires QUITE a bit of testing before being merged

I'm hoping to tackle this during this holiday season when I have more free time.

@fliot
Copy link

fliot commented Feb 9, 2022

I faced the GID:1001 hardcoded issue,
I just reused the MrDonkey07 branch, and I herbly confirm it solved the issue.
Thanks !
If I may, I vote for merge request approval.

@stale
Copy link

stale bot commented Apr 16, 2022

Automatically marked as stale due to no recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@stale
Copy link

stale bot commented Apr 25, 2022

Automatically closed stale item.

@stale stale bot closed this Apr 25, 2022
@FingerlessGlov3s
Copy link

Also hitting the default 1001 bug.

@torsteinelv
Copy link

update?

Copy link
Contributor

@winromulus winromulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winromulus winromulus reopened this Sep 30, 2023
@stale
Copy link

stale bot commented Sep 30, 2023

Removed stale label.

@stale stale bot removed the stale label Sep 30, 2023
Copy link
Contributor

@winromulus winromulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winromulus winromulus merged commit 0c9465b into emberstack:main Sep 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants