Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lib/embulk/input/command.rb #22

Merged
merged 1 commit into from
May 10, 2024
Merged

Remove lib/embulk/input/command.rb #22

merged 1 commit into from
May 10, 2024

Conversation

dmikurube
Copy link
Member

As it is now built based on org.embulk.embulk-plugins, it no longer needs the .rb file. Let's remove it.

@dmikurube dmikurube added this to the v0.2.0 milestone May 9, 2024
@dmikurube dmikurube requested a review from a team as a code owner May 9, 2024 15:18
@dmikurube
Copy link
Member Author

@embulk/embulk-input-command-maintainers Jfyi, I switched its default branch to main from master. master is now locked.

hiroyuki-sato
hiroyuki-sato approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@hiroyuki-sato hiroyuki-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@dmikurube
Copy link
Member Author

Thanks!

@dmikurube dmikurube merged commit b3370ea into main May 10, 2024
4 checks passed
@dmikurube dmikurube deleted the remove-ruby-file branch May 10, 2024 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroyuki-sato hiroyuki-sato hiroyuki-sato approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dmikurube @hiroyuki-sato