Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename GitHub Actions workflow build to check, add explicit strategy and skip unnecessary run in the workflow #261

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Rename GitHub Actions workflow build to check, add explicit strategy and skip unnecessary run in the workflow #261

merged 1 commit into from
Aug 13, 2024

Conversation

dmikurube
Copy link
Member

This pull request follows up to #229 :

  • Rename build to check to be consistent with other repositories under https://github.com/embulk
  • Add explicit strategy: fail-fast: false for each
  • Skip unnecessary run: either of push or pull_request

@dmikurube dmikurube requested a review from a team as a code owner August 13, 2024 04:24
hiroyuki-sato
hiroyuki-sato approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@hiroyuki-sato hiroyuki-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@dmikurube
Copy link
Member Author

Thanks!

@dmikurube dmikurube merged commit 836900c into master Aug 13, 2024
12 checks passed
@dmikurube dmikurube deleted the github-actions-check-strategy-push-or-pull_request branch August 13, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroyuki-sato hiroyuki-sato hiroyuki-sato approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmikurube @hiroyuki-sato