Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the base Gradle wrapper to 7.6.3, the patch release for the 7.6 series #151

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

dmikurube
Copy link
Member

Gradle 7.6.2 and 7.6.3 were patch releases including security fixes.

The org.embulk.embulk-plugins would expect Gradle 8 from its v0.7, but not finally determined.

@dmikurube dmikurube added this to the v0.6.2 milestone Dec 12, 2023
@dmikurube dmikurube requested a review from a team as a code owner December 12, 2023 06:21
Base automatically changed from actions-checkout-v4-java-v4 to master December 12, 2023 07:02
Copy link
Member

@hiroyuki-sato hiroyuki-sato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

| --------------------- | ----------------------- |
| v0.6.2 | Gradle 7.6 (7.6.3) |
| v0.6.1 | Gradle 7.6 (7.6.1) |
| v0.6.0 | Gradle 7.6 (7.6.1) |

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave my thoughts but please ignore them.

What do you think about adding this notice? (I thought about it for a while. But, both versions (7.6.2 and 7.6.3) include security fixes. It is hard to add a notice for every release.)

Gradle 7.6.2 and 7.6.3 were patch releases including security fixes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think it would be too much. Almost all such software can security issues, and it's hard for us to catch up with them always.

On the other hand, this note is just for information. Even while v0.6.1 is buitl with Gradle 7.6.1, v0.6.1 is expected to work with Gradle 7.6.3. Even while v0.6.2 is built with Gradle 7.6.3, v0.6.2 is expected to still work with Gradle 7.6.1.

The users of Gradle (and this plugin) are responsible to catching up with the security news of Gradle. Not our responsibility to provide the information.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you👍. it would be too much.

@dmikurube
Copy link
Member Author

Thanks!

@dmikurube dmikurube merged commit 45e0472 into master Dec 13, 2023
4 checks passed
@dmikurube dmikurube deleted the upgrade-gradle-wrapper-7.6.3 branch December 13, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants