add recolor to make Pop Art

[beartung]

I want to make a pop art photo with wand, but not found any function to manipulate pixels.

The example is here: https://github.com/beartung/pop_art_wand

looks like this:

[beartung]

@dahlia is imagemagick thread safe? If so, I can make a parrel version to do this to faster.

[dahlia]

Thanks for your efforts. The most things are fine, but…

• Why is color_func optional? (It even does nothing when color_func is None.)
• **kwargs seem unnecessary. You can bind fixed arguments to color_func using functools.partial().
• It would be better if color_func returns a Color instead of a string.
• Check to make sure color_func is callable. Raise TypeError otherwise.

@dahlia is imagemagick thread safe? If so, I can make a parrel version to do this to faster.

On Mac at least it’s not thread safe.

[dahlia]

I think we don’t need to check not color_func. ;-)

[dahlia]

Adjustments are find! Could you write some docstring for this method?

[beartung]

😰

[dahlia]

It takes very long time for me… how can we improve its performance?

[beartung]

en... better but not enough, I am working on a c version 😟

[beartung]

@dahlia I have test the c version, only about 2 seconds to dispose of 2102x2102 jpg

using this code:

view = NewWandView(wand);
if (view == (WandView *) NULL) ThrowWandException(wand);
status = UpdateWandViewIterator(view, recolor, (void *)NULL);
if (status == MagickFalse) ThrowWandException(wand);
view = DestroyWandView(view);

full code https://github.com/beartung/pop_art_wand/blob/master/pop_art.c

I will try this method in python later...

[dahlia]

We will go to CFFI from ctypes, and then this part could be written in C.