Open
Conversation
This change adds Cygwin compatibility by generalizing some Windows and Linux functionalities. In particular: * Some tests for Windows are changed into one that consider and accept Cygwin/MSYS2 runtime layers. * Registry values no longer change magick_home; they now influence PATH instead. ctypes on Windows search based on PATH. * msvcrt-specific parts are not changed. * *nix libc loading now default to the BSD "let ctypes find libc" loader, technically correct for every *nix system including Darwin. The hardcoded libc6 value is preserved as a fallback. * *nix libmagick handling now accepts a separate library as found on Cygwin and MinGW.
A previous version forgot to add the original PATH back for prepending. This version fixes the problem and corrects path separater for Unixized Windows environments.
Please squash this. This is embarassing.
Author
|
ping… would anyone take a look at this? It works for me last time I checked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds Cygwin compatibility by generalizing some Windows and Linux functionalities. In particular: