Skip to content

Sampling and interpolation bugfixes#24

Open
Duke-of-Lizard wants to merge 4 commits intomasterfrom
2025-04-sampling_bugfixes
Open

Sampling and interpolation bugfixes#24
Duke-of-Lizard wants to merge 4 commits intomasterfrom
2025-04-sampling_bugfixes

Conversation

@Duke-of-Lizard
Copy link
Copy Markdown
Contributor

fixed two issues encountered in recent projects:

  • avoid memory issues by doing interpolation in batches
  • bugfix in sampling routines where DataFrames were assumed to have natural integer indices

I want to at the very least test our standard project routines to ensure that these changes doing interfere with any of our existing code.

If time allows, we should inspect other parts of EmeraldTriangles to see if this issue with assumed natural indices occurs.

@Duke-of-Lizard Duke-of-Lizard self-assigned this May 21, 2025
@Duke-of-Lizard
Copy link
Copy Markdown
Contributor Author

ran into an issue where the batch interpolation was not being written to the pandas array as expected because I was acutally writing to a copy of it by piping together iloc and loc indexers. I fixed it with this commit:
2feb34d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant