Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expand_bg to text layouting #5365

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion crates/egui/src/widget_text.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ use crate::{
/// RichText::new("colored").color(Color32::RED);
/// RichText::new("Large and underlined").size(20.0).underline();
/// ```
#[derive(Clone, Default, PartialEq)]
#[derive(Clone, PartialEq)]
pub struct RichText {
text: String,
size: Option<f32>,
Expand All @@ -29,6 +29,7 @@ pub struct RichText {
family: Option<FontFamily>,
text_style: Option<TextStyle>,
background_color: Color32,
expand_bg: f32,
text_color: Option<Color32>,
code: bool,
strong: bool,
Expand All @@ -39,6 +40,29 @@ pub struct RichText {
raised: bool,
}

impl Default for RichText {
fn default() -> Self {
Self {
text: Default::default(),
size: Default::default(),
extra_letter_spacing: Default::default(),
line_height: Default::default(),
family: Default::default(),
text_style: Default::default(),
background_color: Default::default(),
expand_bg: 1.0,
text_color: Default::default(),
code: Default::default(),
strong: Default::default(),
weak: Default::default(),
strikethrough: Default::default(),
underline: Default::default(),
italics: Default::default(),
raised: Default::default(),
}
}
}

impl From<&str> for RichText {
#[inline]
fn from(text: &str) -> Self {
Expand Down Expand Up @@ -360,6 +384,7 @@ impl RichText {
family,
text_style,
background_color,
expand_bg,
text_color: _, // already used by `get_text_color`
code,
strong: _, // already used by `get_text_color`
Expand Down Expand Up @@ -425,6 +450,7 @@ impl RichText {
underline,
strikethrough,
valign,
expand_bg,
},
)
}
Expand Down
13 changes: 7 additions & 6 deletions crates/epaint/src/text/text_layout.rs
Original file line number Diff line number Diff line change
Expand Up @@ -753,10 +753,10 @@ fn add_row_backgrounds(job: &LayoutJob, row: &Row, mesh: &mut Mesh) {
return;
}

let mut end_run = |start: Option<(Color32, Rect)>, stop_x: f32| {
if let Some((color, start_rect)) = start {
let mut end_run = |start: Option<(Color32, Rect, f32)>, stop_x: f32| {
if let Some((color, start_rect, expand)) = start {
let rect = Rect::from_min_max(start_rect.left_top(), pos2(stop_x, start_rect.bottom()));
let rect = rect.expand(1.0); // looks better
let rect = rect.expand(expand);
mesh.add_colored_rect(rect, color);
}
};
Expand All @@ -771,18 +771,19 @@ fn add_row_backgrounds(job: &LayoutJob, row: &Row, mesh: &mut Mesh) {

if color == Color32::TRANSPARENT {
end_run(run_start.take(), last_rect.right());
} else if let Some((existing_color, start)) = run_start {
} else if let Some((existing_color, start, expand)) = run_start {
if existing_color == color
&& start.top() == rect.top()
&& start.bottom() == rect.bottom()
&& format.expand_bg == expand
{
// continue the same background rectangle
} else {
end_run(run_start.take(), last_rect.right());
run_start = Some((color, rect));
run_start = Some((color, rect, format.expand_bg));
}
} else {
run_start = Some((color, rect));
run_start = Some((color, rect, format.expand_bg));
}

last_rect = rect;
Expand Down
8 changes: 8 additions & 0 deletions crates/epaint/src/text/text_layout_types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,11 @@ pub struct TextFormat {

pub background: Color32,

/// Amount to expand background fill by.
///
/// Default: 1.0
pub expand_bg: f32,

pub italics: bool,

pub underline: Stroke,
Expand Down Expand Up @@ -298,6 +303,7 @@ impl Default for TextFormat {
line_height: None,
color: Color32::GRAY,
background: Color32::TRANSPARENT,
expand_bg: 1.0,
italics: false,
underline: Stroke::NONE,
strikethrough: Stroke::NONE,
Expand All @@ -315,6 +321,7 @@ impl std::hash::Hash for TextFormat {
line_height,
color,
background,
expand_bg,
italics,
underline,
strikethrough,
Expand All @@ -327,6 +334,7 @@ impl std::hash::Hash for TextFormat {
}
color.hash(state);
background.hash(state);
emath::OrderedFloat(*expand_bg).hash(state);
italics.hash(state);
underline.hash(state);
strikethrough.hash(state);
Expand Down
Loading