Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check for SolidCache #15

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Conversation

stevenchanin
Copy link
Contributor

The stats returned by SolidCache are different from MemCache, so the existing check was failing.

Before we were seeing:

Default Collection
  cache: FAILED Error: 'undefined method `[]' for nil' (0.009s)

now we get

Default Collection
  cache: PASSED Cache is available (entries: 46/268435456, oldest: 331h, max: 1440h, 1 connections) (0.007s)

The stats returned by SolidCache are different from MemCache, so the
existing check was failing.
@emmahsax
Copy link
Owner

emmahsax commented Feb 6, 2025

@stevenchanin All tests passed! Would you like to add something to the CHANGELOG.markdown? Something like this to lines 2-3 (but feel free to change the description text):

* Add a check for SolidCache cache check
  > stevenchanin: https://github.com/emmahsax/okcomputer/pull/15

In a few days, if I don't hear back, I'll just merge the PR and update the file with that above text after merge.

@emmahsax emmahsax merged commit 8d572f7 into emmahsax:main Feb 7, 2025
62 checks passed
@emmahsax
Copy link
Owner

emmahsax commented Feb 7, 2025

Thank you for the contribution! Your change will be in v1.19.0 when it's released! Hopefully that'll happen in the next month for sure.

@stevenchanin
Copy link
Contributor Author

You're very welcome. Thank YOU for resuscitating the gem and moving it forward!

@emmahsax
Copy link
Owner

v1.19.0 has officially been released with this change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants